Sema: Allow more embedded code to reference non-public imports #85317
+267
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
xymus
force-pushed
the
non-neic-funcs-and-typealiases
branch
from
1cce5ae to
c9da23c
Compare
xymus
force-pushed
the
non-neic-funcs-and-typealiases
branch
from
c9da23c to
e04dac5
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test Windows |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test Windows |
1 similar comment
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time, internal import and family don't hide dependencies in non-library-evolution and embedded mode. We can allow the implicitly alway-emit-into-client code of embedded mode to reference non-public dependencies, no need to mark these functions as
@_alwaysEmitIntoClient. We already allowed direct decl references in #85182, adding references via type aliases and conformances here.Followup to #84630 and #85182.
rdar://163965839