Skip to content

[cxx-interop] Reapply implicitly defined copy and move constructors #85559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[cxx-interop] Reapply implicitly defined copy and move constructors #85559

wants to merge 6 commits into from

Conversation

@susmonteiro
Copy link
Contributor

@susmonteiro susmonteiro commented Nov 18, 2025 •
edited
Loading

This patch reapplies #84646 and #85236:

If a C++ type doesn't have a user provided copy constructor, Clang will declare one implicitly, unless one of its fields is not copy-constructible. Clang assumes that any std::vector is always copy-constructible, including a std::vector of a non-copy constructible type. So, let's use the CxxValueSemantics implemented in #84340 to figure out if we should ask Clang to define the copy constructor for such types.

This also includes types that have a defaulted, user-provided copy constructor.

These patches were reverted (#85331) because they triggered a cycle in the CxxValueSemantics requests. After #85485, these cycles have been prevented and we can safely re-land those patches.

rdar://151870709
rdar://152496447

@susmonteiro susmonteiro added the c++ interop Feature: Interoperability with C++ label Nov 18, 2025
@susmonteiro
Copy link
Contributor Author

susmonteiro commented Nov 18, 2025

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/reapply-implicit-constructors branch from 39b6e3b to b7292a7 Compare November 18, 2025 16:00
@susmonteiro
Copy link
Contributor Author

susmonteiro commented Nov 18, 2025

@swift-ci please smoke test

@susmonteiro susmonteiro mentioned this pull request Nov 19, 2025
Merged
@susmonteiro susmonteiro force-pushed the susmonteiro/reapply-implicit-constructors branch from b7292a7 to ce6451b Compare November 20, 2025 13:05
@susmonteiro susmonteiro force-pushed the susmonteiro/reapply-implicit-constructors branch from ce6451b to 93ee8af Compare November 20, 2025 13:07
@susmonteiro
Copy link
Contributor Author

susmonteiro commented Nov 20, 2025

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan will be requested when the pull request is marked ready for review egorzhdan is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun will be requested when the pull request is marked ready for review Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui will be requested when the pull request is marked ready for review j-hui is a code owner

@hnrklssn hnrklssn Awaiting requested review from hnrklssn hnrklssn will be requested when the pull request is marked ready for review hnrklssn is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall will be requested when the pull request is marked ready for review rjmccall is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax will be requested when the pull request is marked ready for review beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder will be requested when the pull request is marked ready for review ian-twilightcoder is a code owner

Assignees

No one assigned

Labels

c++ interop Feature: Interoperability with C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@susmonteiro