Sema: allow applying @objc @implementation on extensions to internally imported types - #90133
Draft
nkcsgexi wants to merge 1 commit into
Draft
Sema: allow applying @objc @implementation on extensions to internally imported types#90133nkcsgexi wants to merge 1 commit into
nkcsgexi wants to merge 1 commit into
Conversation
…y imported types Extend the existing @c/@objc @implementation hidden-dependency exemption to cover the extension's extended-type and where-clause checks rdar://178750930
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
This looks generally reasonable, but I think it's missing some test coverage for like adding protocol conformances to the |
Contributor
Author
|
Great catch! Let me add more test coverage and ensure this new exception doesn't regress textual interface validity. |
nkcsgexi
marked this pull request as draft
June 24, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the existing @c/@objc @implementation hidden-dependency exemption to cover the extension's extended-type and where-clause checks
rdar://178750930