[cxx-interop] Emit lvalue-to-rvalue conversion in synthesized bit-field getter#90560
Merged
Conversation
j-hui
requested review from
Xazax-hun,
beccadax,
egorzhdan,
hnrklssn,
ian-twilightcoder,
patrykstefanski and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Jul 9, 2026
Xazax-hun
approved these changes
Jul 10, 2026
egorzhdan
approved these changes
Jul 10, 2026
j-hui
force-pushed
the
cxx-bitfield-access
branch
from
2995698 to
f8bde2c
Compare
Contributor
Author
|
@swift-ci please smoke test |
…ld getter The getter body previously read the member as a prvalue, which tripped Clang's C++11 constant evaluator assertion and crashed swift-frontend when IR-generating bit-field accessors under -cxx-interoperability-mode. rdar://158308810
j-hui
force-pushed
the
cxx-bitfield-access
branch
from
f8bde2c to
d521a83
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
Contributor
Author
|
@swift-ci please smoke test windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getter body previously read the member as a prvalue, which tripped Clang's C++11 constant evaluator assertion and crashed swift-frontend when IR-generating bit-field accessors under -cxx-interoperability-mode.
rdar://158308810