Fix multiple bugs in GDB RP functionality#222
Merged
MaxDesiatov merged 9 commits intomainfrom Nov 1, 2025
Merged
Conversation
MaxDesiatov
commented
Oct 31, 2025
fffd586 to
d91a351
Compare
MaxDesiatov
commented
Oct 31, 2025
kateinoigakukun
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple issues with GDB RP implementation are addressed here:
withThrowingTaskGroupfor existingwithThrowingDiscardingTaskGroupto propagate debugger handler cancellation error.isNoAckModeActiveset too early inGDBHostCommandDecoder, which led to non-deterministic issues with command decoding.enum BreakpointStatewithinDebuggerto properly express its state machine nature and correctly report exit codes of WASI modules to the debugger client.Execution.CurrentMemory.mayUpdateCurrentInstancewithout thefrom:parameter, which means we no longer go through an early return path and now correctly set linear memory instance when resuming from a breakpoint.DebuggerInstructionMapping, where we had to peek outside of an array slice and use Array'sselfinstead of localslice.