Enable use of package in code built with CMake#243
Merged
MaxDesiatov merged 2 commits intomainfrom Dec 26, 2025
Merged
Conversation
`package` keyword is only available when `-package-name` option is passed, which is not the case by default when building with CMake. This required use of `@testable`, which makes testing code not buildable with CMake when attempting to replace use of `@testable` with `package`. Let's pass `-package-name` to fix this.
kateinoigakukun
approved these changes
Dec 26, 2025
MaxDesiatov
added a commit
that referenced
this pull request
Jan 3, 2026
Following up on #243 to make relevant code actually usable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packagekeyword is only available when-package-nameoption is passed, which is not the case by default when building with CMake. This required use of@testablein our tests instead ofpackage. Let's pass-package-nameto fix this.The long term goal is to make parts of
WasmKitTestsbuildable with CMake to make it available it in code that can't be built with SwiftPM (e.g. when linking with LLVM).