Skip to content

avoid indentation warning#2074

Closed
ajrh1 wants to merge 2 commits intoswig:masterfrom
ajrh1:fix-gcc-indentation-warning
Closed

avoid indentation warning#2074
ajrh1 wants to merge 2 commits intoswig:masterfrom
ajrh1:fix-gcc-indentation-warning

Conversation

@ajrh1
Copy link
Contributor

@ajrh1 ajrh1 commented Aug 31, 2021

gcc-11 complains about the indentation here. inserting a newline seems like the simplest fix

modules/swig/perl/obj/etp.swig.cpp:10135:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
10135 | if (argvi >= items) EXTEND(sp, argvi+1); ST(argvi) = d3.sv; argvi++ ;

@vadz vadz added the Perl label Aug 31, 2021
@vadz vadz added this to the swig-4.1 milestone Aug 31, 2021
@vadz
Copy link
Member

vadz commented Aug 31, 2021

Thanks!

FWIW this looks good to me and ought to be merged, I think. If there are no objections, I'll do it before the (long past) 4.1 milestone.

P.S. AppVeyor failures are spurious/unrelated.

@ojwb
Copy link
Member

ojwb commented Sep 29, 2021

@vadz Looks sensible to me - I'd say just get it merged, assuming the generated code with this change looks right.

@vadz
Copy link
Member

vadz commented Oct 3, 2021

I've merged the latest master into this branch to rerun the CI builds, if/when the Perl one passes, I'm going to cherry pick the original commit to master (i.e. this branch should not be merged any more, as this would result in an unnecessary weird criss-cross merge).

@vadz
Copy link
Member

vadz commented Oct 3, 2021

There was a failure, but a completely unrelated one, so I'm still merging this.

Thanks again!

@vadz vadz closed this in 6c59cae Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants