Closed
Conversation
Member
|
Thanks! FWIW this looks good to me and ought to be merged, I think. If there are no objections, I'll do it before the (long past) 4.1 milestone. P.S. AppVeyor failures are spurious/unrelated. |
Member
|
@vadz Looks sensible to me - I'd say just get it merged, assuming the generated code with this change looks right. |
Member
|
I've merged the latest master into this branch to rerun the CI builds, if/when the Perl one passes, I'm going to cherry pick the original commit to master (i.e. this branch should not be merged any more, as this would result in an unnecessary weird criss-cross merge). |
Member
|
There was a failure, but a completely unrelated one, so I'm still merging this. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc-11 complains about the indentation here. inserting a newline seems like the simplest fix
modules/swig/perl/obj/etp.swig.cpp:10135:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
10135 | if (argvi >= items) EXTEND(sp, argvi+1); ST(argvi) = d3.sv; argvi++ ;