chore(components): rename post-header slots to improve clarity and consistency
#6780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
🦋 Changeset detectedLatest commit: f0a8430 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alionazherdetska
changed the title
post-header slots to improve clarity and consistency
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the post-header component by renaming its slots to improve clarity and consistency across the Swiss Post Design System. The slot names are being updated to be more intuitive and better aligned with their purpose, marking this as a major breaking change for the components package.
Key Changes
- Renamed 6 slots in the
post-headercomponent for improved semantic clarity - Updated all component documentation, examples, test fixtures, and integration code to use new slot names
- Added comprehensive changeset documenting the breaking changes
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/components/src/components/post-header/post-header.tsx |
Updated JSDoc comments, slot names in render methods, and querySelector selectors to use new slot names |
packages/styles/src/components/header/_post-header.scss |
Updated CSS selectors targeting the renamed slots |
packages/documentation/src/stories/components/header/header.stories.ts |
Updated header story to use new slot names |
packages/documentation/src/stories/components/header/renderers/target-group.ts |
Updated target group renderer to use audience slot |
packages/documentation/src/stories/components/header/renderers/meta-navigation.ts |
Updated meta navigation renderer to use global-nav-secondary slot |
packages/documentation/src/stories/components/header/renderers/main-navigation.ts |
Updated main navigation renderer to use main-nav slot |
packages/documentation/src/stories/raw-components/megadropdown/megadropdown.stories.ts |
Updated megadropdown decorator to use new slot names |
packages/documentation/src/stories/components/back-to-top/back-to-top.stories.ts |
Updated back-to-top story decorator to use new slot names |
packages/nextjs-integration/src/app/ssr/layout.tsx |
Updated Next.js integration example to use new slot names |
packages/components/src/index.html |
Updated playground HTML file to use new slot names |
packages/components/cypress/fixtures/post-mainnavigation.test.html |
Updated test fixture to use new slot names |
packages/components/cypress/fixtures/post-mainnavigation-overflow.test.html |
Updated test fixture to use new slot names |
packages/components-angular/projects/consumer-app/src/app/app.component.html |
Updated Angular consumer app to use new slot names |
.changeset/moody-rivers-flash.md |
Added changeset documenting the breaking changes with migration guide |
Comment on lines
53
to
54
| {/* Meta navigation */} | ||
| <ul slot="global-nav-secondary"> |
There was a problem hiding this comment.
Inconsistent indentation: the comment has 8 spaces of indentation while the <ul> tag below it has 6 spaces. Both should have the same indentation level (6 spaces) to match the surrounding code structure.
gfellerph
requested changes
Dec 8, 2025
packages/documentation/src/stories/components/header/renderers/target-group.ts
Show resolved
Hide resolved
gfellerph
approved these changes
Dec 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
This PR renames slots in the
post-headercomponent to improve clarity and consistency with design specifications. The changes align slot names with their semantic purpose.🚀 Demo
Header docs
🔮 Design review
📝 Checklist