Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/org/swisspush/metrics/MetricsModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@ public void start(Promise<Void> startPromise) {
}
timers = new HashMap<>() ;
gauges = new ConcurrentHashMap<>() ;
JmxReporter.forRegistry( metrics ).build().start() ;
JmxReporter.forRegistry( metrics )
.createsObjectNamesWith(new SimpleObjectNameFactory())
.build().start() ;

logger.info("Register consumer for event bus address '"+address+"'");
logger.info("Register consumer for event bus address '" + address + "'");
vertx.eventBus().consumer( address, this ) ;

startPromise.complete();
Expand Down
33 changes: 33 additions & 0 deletions src/main/java/org/swisspush/metrics/SimpleObjectNameFactory.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package org.swisspush.metrics;

import com.codahale.metrics.jmx.ObjectNameFactory;
import io.vertx.core.logging.Logger;
import io.vertx.core.logging.LoggerFactory;

import javax.management.MalformedObjectNameException;
import javax.management.ObjectName;

/**
* keep the mbean name formated as io.dropwizard.metrics V 4.0.2
*/
public class SimpleObjectNameFactory implements ObjectNameFactory {
private static final Logger LOGGER = LoggerFactory.getLogger(SimpleObjectNameFactory.class);

@Override
public ObjectName createName(String type, String domain, String name) {
try {
ObjectName objectName = new ObjectName(domain, "name", name);
if (objectName.isPattern()) {
objectName = new ObjectName(domain, "name", ObjectName.quote(name));
}
return objectName;
} catch (MalformedObjectNameException e) {
try {
return new ObjectName(domain, "name", ObjectName.quote(name));
} catch (MalformedObjectNameException e1) {
LOGGER.warn("Unable to register {} {}", type, name, e1);
throw new RuntimeException(e1);
}
}
}
}