Improve IpcParsedCommand domain message info. - #112
Merged
Conversation
yellows8
reviewed
Jun 12, 2018
| DomainMessageType_Invalid = 0, | ||
| DomainMessageType_SendMessage = 1, | ||
| DomainMessageType_Close = 2, | ||
| } DomainMessageType; |
Contributor
There was a problem hiding this comment.
Ipc prefix missing + elsewhere.
Contributor
Author
There was a problem hiding this comment.
I was matching the existing style -- @plutooo called the domain header type "DomainMessageHeader", does that also need to change?
yellows8
reviewed
Jun 12, 2018
| case DomainMessageType_Close: | ||
| break; | ||
| default: | ||
| return 0xF601; |
Contributor
There was a problem hiding this comment.
Does official sw return this?
Contributor
Author
There was a problem hiding this comment.
Fixed to return what official sw does.
Output errcode for parse now matches official sw for the error cases we check.
yellows8
reviewed
Jun 17, 2018
| break; | ||
| default: | ||
| return 0xF601; | ||
| return 0x1A60A; |
Contributor
There was a problem hiding this comment.
Change these to a new libnx error.
Contributor
There was a problem hiding this comment.
I think this is supposed to match official sw, not sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's hard to use IpcParsedCommand for domain messages.
This fixes that.