fix: keep the Reply Drafter output to only the replies#2278
Merged
Conversation
Small on-device models leak preamble and trailing commentary despite the prompt, which parseSuggestions then turned into tappable, pasteable "replies". - Prompt asks the model to wrap the replies in <replies> tags. - parseSuggestions keeps only the text between the tags and discards everything outside; falls back to the whole output when the tags are absent so the screen is never empty, and strips wrapping quotes. - Add unit tests for region extraction, no-tag fallback, a missing close tag, and quote stripping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small on-device models (Gemini Nano / Gemma 3n) leak preamble ("Sure, here are some replies:") and trailing commentary despite the prompt.
parseSuggestions()split on lines and turned that prose into tappable, pasteable "replies". The prompt alone can't guarantee clean output on a small model, so the contract is now enforced in the parser.<replies>/</replies>tags.parseSuggestions()keeps only the text between those tags and discards everything outside. It falls back to the whole output when the tags are absent — so the screen is never left empty — and strips wrapping quotes.Test plan
./gradlew compileDebugKotlin testDebugUnitTest— compiles; 11ReplyDrafterPrompttests pass.Closes #2277