feat: use the app NavBar in the AI activities (#2296)#2297
Merged
Conversation
Reply Drafter and Screen Highlights both used a stock Material 3 TopAppBar (default surface-coloured), which read as themed but looked different from every Settings screen — those use the app's custom NavBar with a red gradient and onPrimary chrome. Make NavBar's navController parameter nullable (only used for the back-button auto-detect + default popBackStack, both already override-able) and swap the AI screens over. Removes the bottom Close button and the bare TopAppBar; the back arrow in the NavBar drives onClose. Closes #2296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two AI activities (Reply Drafter, Screen Highlights) shipped with a stock Material 3
TopAppBarthat read as themed but looked different from every Settings screen — those use the app's customNavBarwith a red gradient and onPrimary chrome. This swap brings them in line.NavBar'snavControllerparameter is now nullable. It was already only used for the back-button auto-detect (whenshowBackButtonis null) and the defaultpopBackStack()action (whenonBackPressedis null); both call sites already use safe access.ReplyDrafterScreenandScreenHighlightsScreenswap theirTopAppBarblock forNavBar(title=…, showBackButton=true, onBackPressed=onClose).Textand bottom CloseActionButtonwere already removed in the previous step on this branch; this commit only changes the top-bar styling.Closes #2296
Test plan
./gradlew compileDebugKotlin testDebugUnitTest installDebug