Show the macOS Computer Name in Switchify Android - #559
Merged
Conversation
This was referenced Aug 10, 2026
Contributor
Author
|
@greptileai review |
Greptile SummaryThis change makes the Mac’s localized computer name available in the connected GATT status response while retaining the generic Switchify PC BLE advertisement name. The earlier host-name exposure report is disproved: the executed comparison confirmed that nearby BLE advertisements no longer use the personalized computer name. Confidence Score: 5/5No blocking failure remains. The executed validation confirmed the fixed advertising name and personalized connected status payload, with no accepted blocking findings.
What T-Rex did
Reviews (3): Last reviewed commit: "Keep the BLE advertisement name private" | Re-trigger Greptile |
Address Greptile P1 by retaining the personalized computer name only in the status characteristic.
Contributor
Author
|
@greptileai review |
Contributor
Author
|
Final status for
Left as a draft for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
displayNameSwitchify PCSwitchify PCas the blank/unavailable fallbackRoot cause
CoreBluetooth exposes a generic GAP name (
Mac) to Android. The desktop status payload also used a fixed product name, so Android had no authoritative friendly machine name.Privacy and compatibility
The personalized name is not broadcast in BLE advertising or logged. No protocol version, UUID, desktop identity, pairing, storage, Windows behavior, or diagnostics change. Coordinated Android fix: switchifyapp/switchify-android#2774.
Validation
npm run lintnpm test -- --run(55 passed)npm run buildcargo fmt --manifest-path src-tauri/Cargo.toml --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warningscargo test --manifest-path src-tauri/Cargo.toml(140 passed)npm run macos:runbundle and designated-requirement verificationCloses #558