feat: add solarize filter and update documentation - #94
Merged
Conversation
I-got-mine
marked this pull request as draft
June 16, 2026 06:48
I-got-mine
marked this pull request as ready for review
June 16, 2026 06:49
Owner
|
Merged — thank you, this is a great contribution! 🎉 I built it locally and ran the full suite to confirm: clean build with no warnings, 38/38 integration tests pass, A few things I appreciated:
Tiny non-blocking nits I'll tidy in a follow-up so I'm not bouncing the PR back to you: the help string says "invert channels >= T" while the code uses Thanks again for adding a filter and leaving the surrounding code a little better than you found it. Hope to see more from you! 🙏 |
swperb
added a commit
that referenced
this pull request
Jun 16, 2026
Match the help string to the code (`> T`, not `>= T`) and drop a stray double-space / space-before-paren. No behaviour change. Follow-up to the contributed solarize filter in #94. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the solarize filter and changed documentation per description. also cleaned up some if statements in rotate that were preventing make from completing. passes tests.