Skip to content

feat: add solarize filter and update documentation - #94

Merged
swperb merged 1 commit into
swperb:mainfrom
I-got-mine:add-solarize
Jun 16, 2026
Merged

feat: add solarize filter and update documentation#94
swperb merged 1 commit into
swperb:mainfrom
I-got-mine:add-solarize

Conversation

@I-got-mine

@I-got-mine I-got-mine commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

added the solarize filter and changed documentation per description. also cleaned up some if statements in rotate that were preventing make from completing. passes tests.

@I-got-mine
I-got-mine marked this pull request as draft June 16, 2026 06:48
@I-got-mine
I-got-mine marked this pull request as ready for review June 16, 2026 06:49
@swperb
swperb merged commit 16694c2 into swperb:main Jun 16, 2026
11 checks passed
@swperb

swperb commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Merged — thank you, this is a great contribution! 🎉

I built it locally and ran the full suite to confirm: clean build with no warnings, 38/38 integration tests pass, solarize and solarize=64 both produce correct output, and rotate still expands the canvas as expected.

A few things I appreciated:

  • The solarize implementation is clean and idiomatic — it follows the in-place point-filter convention, leaves the alpha channel untouched, and the optional [=T] threshold (default 128) is a nice touch.
  • Registered correctly in the FILTERS[] table and documented in the README's Colour list — exactly the pattern we ask for in CONTRIBUTING.md.
  • The brace cleanup in f_rotate is welcome too; one statement per line with explicit braces is the style we prefer.

Tiny non-blocking nits I'll tidy in a follow-up so I'm not bouncing the PR back to you: the help string says "invert channels >= T" while the code uses >, and there's a stray double-space. Nothing that affects behaviour.

Thanks again for adding a filter and leaving the surrounding code a little better than you found it. Hope to see more from you! 🙏

swperb added a commit that referenced this pull request Jun 16, 2026
Match the help string to the code (`> T`, not `>= T`) and drop a stray
double-space / space-before-paren. No behaviour change. Follow-up to the
contributed solarize filter in #94.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@I-got-mine
I-got-mine deleted the add-solarize branch June 16, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants