Migrate to use swxsoc from sdc_aws_utils - #17
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Lambda processing codebase from sdc_aws_utils to the consolidated swxsoc package, updating imports/config reconfiguration in the processor and tests, and aligning dependency lists accordingly.
Changes:
- Replaced
sdc_aws_utilsdependencies withswxsocacross dev and mission-specific requirements. - Updated processor code to use
swxsocS3/config/filename utilities and adjusted MetaTracker wiring accordingly. - Updated test fixtures/imports to use
swxsoc.reconfigure()and added aruff.tomllint ignore configuration.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| ruff.toml | Adds Ruff lint ignore configuration for the repo. |
| requirements.dev.txt | Swaps sdc_aws_utils dependency for swxsoc in the dev/test environment. |
| lambda_function/tests/test_processor.py | Consolidates imports and removes now-unneeded noqa markers; keeps logging config. |
| lambda_function/tests/conftest.py | Switches mission reconfiguration to swxsoc.reconfigure(). |
| lambda_function/swxsoc_pipeline-requirements.txt | Updates pipeline dependency from sdc_aws_utils to swxsoc. |
| lambda_function/src/file_processor/file_processor.py | Migrates AWS/config/filename handling to swxsoc APIs and updates MetaTracker parser usage. |
| lambda_function/padre-requirements.txt | Updates PADRE Lambda dependency from sdc_aws_utils to swxsoc. |
| lambda_function/impax-requirements.txt | Updates iMPAX Lambda dependency from sdc_aws_utils to swxsoc. |
| lambda_function/hermes-requirements.txt | Updates HERMES Lambda dependency from sdc_aws_utils to swxsoc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage ? 51.79%
=======================================
Files ? 2
Lines ? 195
Branches ? 0
=======================================
Hits ? 101
Misses ? 94
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
sdc_aws_utilstoswxsoclibrary: Replace deprecatedsdc_aws_utilspackage with consolidatedswxsocutilities for S3 I/O, config handling, and filename parsing; update all imports and function signatures accordingly (removesenvironmentparameter fromget_instrument_bucket())Add comprehensive AGENTS.md documentation: Create AI-agent-ready guide documenting project overview, testing/build commands, architecture decisions, config baking strategy, and common development tasks to enable immediate productivity
Add ruff linting configuration and minor code cleanup (test imports, shebang,
psycopg2-binarydependency) to standardize code quality across the project