Add evil-fringe-mark to +spacemacs/spacemacs-evil #16770
Conversation
|
Have you try it with |
| (defun spacemacs-evil/init-evil-fringe-mark () | ||
| (use-package evil-fringe-mark | ||
| :config | ||
| (setq-default evil-fringe-mark-show-special t) |
There was a problem hiding this comment.
I think it would be better to set options in the :init or :custom block. It makes them easier to override by users when the package is deferred.
| (use-package evil-fringe-mark | ||
| :config | ||
| (setq-default evil-fringe-mark-show-special t) | ||
| (global-evil-fringe-mark-mode))) |
There was a problem hiding this comment.
If we add this package, it should be deferred, and the mode should not be enabled by default. It would make sense to add a toggle as for evil-visual-mark-mode, SPC t ' seems logical as a key binding.
smile13241324
left a comment
smile13241324
left a comment
There was a problem hiding this comment.
Not a bad idea though I think it makes sense to have this configurable in the layer and to have a toggle for this feature as well.
Given the performance concerns from @sunlin7 the package should be disabled by default. Also please only install the package when it is used.
|
Looks like evil fridge mode had not received any commit in the last 6 years. Given thst the package seems dead I am hesitant to add it to Spacemacs. |
4 participants
This PR adds the evil-fringe-mark package.
I configured it to display both user and special marks globally.
Thanks