Remove GOPATH Use, Simplify RPM Spec #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
approved these changes
Oct 14, 2021
dist/rpm/singularity-ce.spec.in
Outdated
| make DESTDIR=$RPM_BUILD_ROOT install man | ||
| make -C builddir DESTDIR=$RPM_BUILD_ROOT install man | ||
|
|
||
| %if "%{suse_version}" == "11" |
Member
There was a problem hiding this comment.
Let's drop this while we are at it - SLES11 is EOL.
Member
Author
There was a problem hiding this comment.
Done. Dropped RHEL 6 workaround also.
dtrudg
approved these changes
Oct 14, 2021
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Remove unnecessary uses of
GOPATHinINSTALL.mdand RPM spec. Simplify RPM spec.This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).