[Enhancer] create Content Repository Enhancer #168
Conversation
andrey1s
commented
Feb 26, 2016
andrey1s
commented
| Q | A |
|---|---|
| Bug fix? | [no] |
| New feature? | [yes] |
| BC breaks? | [no] |
| Deprecations? | [no] |
| Tests pass? | [yes] |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | #745 |
| private $source; | ||
|
|
||
| /** | ||
| * ContentRepositoryEnhancer constructor. |
There was a problem hiding this comment.
lets remove this line, it does not say anything.
|
i think this makes sense when you have a database layer that does not provide you with relations to automatically load the content. can you please check where we can add this to the documentation? |
| use Symfony\Cmf\Component\Routing\RouteObjectInterface; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
|
|
||
| class ContentRepositoryEnhancer implements RouteEnhancerInterface |
There was a problem hiding this comment.
please add a short description what this enhancer is doing
There was a problem hiding this comment.
can you add rules for the styleci.io?
| private $source; | ||
|
|
||
| /** | ||
| * @param ContentRepositoryInterface $contentRepository repository for the search content |
There was a problem hiding this comment.
Maybe "repository to search for the content" is better?
|
I like this feature, it's a very effective and simple way to support content in ORM databases. |
|
i created symfony-cmf/routing-bundle#337 for the bundle. @andrey1s would you have time to work on this? |
4 participants
