[Store] Do not allow to store state in Indexer type #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Feature
lyrixx
force-pushed
the
store-indexer-no-state
branch
from
e11d79f to
e2cdac7
Compare
lyrixx
commented
Nov 26, 2025
| return (new PhpCsFixer\Config()) | ||
| // @see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7777 | ||
| ->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect()) | ||
| ->setUnsupportedPhpVersionAllowed(true) |
Member
Author
There was a problem hiding this comment.
I'm using PHP8.5. This allow me to run php-cs-fixer.
Obviously, we must not use PHP8.5 features. The CI will catch us if we do :)
| $platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client()); | ||
| $vectorizer = new Vectorizer($platform, $embeddings = 'text-embedding-3-small'); | ||
| $indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger()); | ||
| $indexer->index($documents); |
Member
Author
There was a problem hiding this comment.
$documents, are already set in the Loader. No need to repeat it here.
lyrixx
commented
Nov 26, 2025
lyrixx
force-pushed
the
store-indexer-no-state
branch
2 times, most recently
from
645485a to
2bf1345
Compare
Life is always easier without storing state in a service
lyrixx
force-pushed
the
store-indexer-no-state
branch
from
2bf1345 to
e56e022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Life is always easier without storing state in a service