Skip to content

Remove duplicated rules #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Jul 31, 2020
Merged

Remove duplicated rules #1134

javiereguiluz merged 1 commit into from
Jul 31, 2020

Conversation

@michaelKaefer
Copy link
Contributor

@michaelKaefer michaelKaefer commented Jul 19, 2020 •
edited
Loading

Remove duplicated rules which are already included in @Symfony rules.

To verify that the @Symfony rules include the removed rules see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.16/src/RuleSet.php or run:

php php-cs-fixer.phar describe @Symfony | grep -A 3 array_syntax
php php-cs-fixer.phar describe @Symfony | grep -A 3 no_superfluous_phpdoc_tags
// ...

@michaelKaefer
Remove duplicated rules
c44b3ee 
Remove duplicated rules which are already included in @symfony rules.

To verify that the `@Symfony` rules include the removed rules see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.16/src/RuleSet.php or run:
```bash 
php php-cs-fixer.phar describe @symfony | grep -A 3 array_syntax
php php-cs-fixer.phar describe @symfony | grep -A 3 no_superfluous_phpdoc_tags
// ...
```
@javiereguiluz
Copy link
Member

javiereguiluz commented Jul 31, 2020

Thanks Michael. I like this kind of contributions because even if it looks small, it removes "noise" and simplifies maintenance. Thanks!

@javiereguiluz javiereguiluz merged commit bcdd588 into symfony:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelKaefer @javiereguiluz