replace deprecated method call #1505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
requested changes
Apr 3, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Howdy @tacman - this was already done in #1464 and released in v1.57.0.
I think you might need to rebase your local main branch of MakerBundle to ensure the changes are pulled in.
git checkout maingit fetch upstream(or whatever the remote tosymfony/maker-bundleis called on your machine)git rebase upstream/maingit push origin(or whatever the remote name is called totacman/maker-bundle)
I go into more detail on rebasing in #1393 (comment)
jrushlow
added
Feature
Contributor
Author
|
DOH! I forgot that the code I was working on was created (via the maker) a few weeks ago, and didn't check! Sigh. |
Collaborator
|
No worries! thank you for submitting the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2 of the helper uses validateEmailConfirmationFromRequest, this PR makes the correct call to avoid the deprecation warning.