[sfhackday2019] Fixing tests #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romaricdrigon
added
Bug
romaricdrigon
approved these changes
Nov 23, 2019
Contributor
romaricdrigon
left a comment
romaricdrigon
left a comment
There was a problem hiding this comment.
Tests are in a better state ; there are some SF5-related issues, but those are also on master.
Member
|
Thank you for your detailed work on this Vladimir and Romaric - really happy to have the tests in a better state (even if we're waiting for some Symfony5-related tthings still) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve symlinking phpunit-bridge inside testing flex project.