Skip to content

[sfhackday2019] Fixing tests #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2019
Merged

[sfhackday2019] Fixing tests #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93e0e7e
fixing tests
sadikoff Nov 23, 2019
39d5f4b
remove wrong use statement
sadikoff Nov 23, 2019
4b2a876
configure dev and stable-dev works with php7.2
sadikoff Nov 23, 2019
4712a5d
move clearing cache before premake
sadikoff Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ matrix:
fast_finish: true
include:
- php: 7.3
- php: 7.1
- php: 7.2
env: MAKER_TEST_VERSION=stable-dev
- php: 7.1
- php: 7.2
env: MAKER_TEST_VERSION=dev

before_install:
Expand Down
3 changes: 0 additions & 3 deletions src/Test/MakerTestDetails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ final class MakerTestDetails
private $guardAuthenticators = [];

/**
* @param MakerInterface $maker
* @param array $inputs
*
* @return static
*/
public static function createTest(MakerInterface $maker, array $inputs)
Expand Down
11 changes: 5 additions & 6 deletions src/Test/MakerTestEnvironment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,11 @@ private function preMake()

public function runMaker()
{
$this->preMake();

// Lets remove cache
$this->fs->remove($this->path.'/var/cache');

$this->preMake();

// We don't need ansi coloring in tests!
$testProcess = MakerTestProcess::create(
sprintf('php bin/console %s %s --no-ansi', $this->testDetails->getMaker()::getCommandName(), $this->testDetails->getArgumentsString()),
Expand Down Expand Up @@ -350,12 +350,11 @@ private function buildFlexSkeleton()
// fetch a few packages needed for testing
MakerTestProcess::create('composer require phpunit browser-kit symfony/css-selector --prefer-dist --no-progress --no-suggest', $this->flexPath)
->run();
$this->fs->remove($this->flexPath.'/vendor/symfony/phpunit-bridge');

if ('\\' !== \DIRECTORY_SEPARATOR) {
$this->fs->symlink('../../../../../../vendor/symfony/phpunit-bridge', './vendor/symfony/phpunit-bridge');
} else {
$this->fs->mirror(\dirname(__DIR__, 2).'/vendor/symfony/phpunit-bridge', $this->flexPath.'/vendor/symfony/phpunit-bridge');
$this->fs->remove($this->flexPath.'/vendor/symfony/phpunit-bridge');

$this->fs->symlink($rootPath.'/vendor/symfony/phpunit-bridge', $this->flexPath.'/vendor/symfony/phpunit-bridge');
}

// temporarily ignoring indirect deprecations - see #237
Expand Down