Skip to content

Allow released versions of the deprecation contract #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Allow released versions of the deprecation contract #746

merged 1 commit into from
Nov 25, 2020

Conversation

@stof
Copy link
Member

@stof stof commented Nov 25, 2020

This ensures that the package can be installed with stable as minimum stability.

@stof
Copy link
Member Author

stof commented Nov 25, 2020 •
edited
Loading

The cause of introducing a faulty constraint is probably that the contributor adding it in #728 ran composer require symfony/deprecation-contracts, letting Composer guess the constraint. But this guessing respect the minimum-stability of the project, and this project defines dev as the min stability.

@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label Nov 25, 2020
@jrushlow
Copy link
Collaborator

jrushlow commented Nov 25, 2020 •
edited
Loading

contributor adding it in #728 ran composer require symfony/deprecation-contracts

That's exactly what happened. Good catch!

@stof
Copy link
Member Author

stof commented Nov 25, 2020

Good catch!

Well, that was actually catched because someone complain on Slack that composer require symfony/maker-bundle was broken.

@weaverryan
Copy link
Member

weaverryan commented Nov 25, 2020

Thank you for the quick PR Stof!

@weaverryan weaverryan merged commit 40b49ab into main Nov 25, 2020
@weaverryan weaverryan deleted the allow_deprecation_releases branch November 25, 2020 17:23
@weaverryan
Copy link
Member

weaverryan commented Nov 25, 2020

Tagged! I think we could bump even lower to ^2.1, right?

jrushlow added a commit to jrushlow/maker-bundle that referenced this pull request Nov 25, 2020
@jrushlow
lower symfony/contracts dependency version a tad bit more
6be1e9e 
PR symfony#728 introduces symfony/deprecations-contracts at version `^2.3`
which prevented some users from using maker bundle.

PR symfony#746 fixed the reported issue by lowering the version constraint
to `^2.2`. But in reality we can lower it even further to `2.1` as
this is when `symfony/deprecation-contracts` was introduced.
@jrushlow jrushlow mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stof @jrushlow @weaverryan