lower symfony/contracts dependency version a tad bit more #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR symfony#728 introduces symfony/deprecations-contracts at version `^2.3` which prevented some users from using maker bundle. PR symfony#746 fixed the reported issue by lowering the version constraint to `^2.2`. But in reality we can lower it even further to `2.1` as this is when `symfony/deprecation-contracts` was introduced.
Collaborator
Author
|
@stof think we can go even lower w/ this constraint. Only thought I have - will going lower than |
Member
|
Well, support for PHP 8 exists only in 2.2+ of the contracts. I think it is fine to depend on 2.2+. There is nothing forbidding to upgrade from 2.1 to 2.2 in a project (the only blockage to upgrade to the previously required 2.3 is that it does not exist yet...) |
Collaborator
Author
|
good point, thanks for the feedback @stof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #728 introduced
symfony/deprecations-contractsat version^2.3which prevented some users from using maker bundle.PR #746 fixed the reported issue by lowering the version constraint to
^2.2. But in reality we can lower it even further to2.1asthis is when
symfony/deprecation-contractswas introduced.