[HttpClient] Add JsonMockResponse
#18247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
force-pushed
the
feature/18230-add-json-mock-response
branch
from
f469877 to
01e1d4a
Compare
MrYamous
approved these changes
Apr 24, 2023
OskarStark
reviewed
Apr 26, 2023
http_client.rst
Outdated
| ; | ||
| }; | ||
| You can also use :class:`Symfony\\Component\\HttpClient\\Response\\JsonMockResponse` which automatically encode |
Contributor
There was a problem hiding this comment.
We should explain before and after, like:
"To return json, you would normally do ......", CODE-EXAMPLE, "you can use the following way instead...." CODE-EXAMPLE with JsonMockResponse
WDYT?
Contributor
Author
There was a problem hiding this comment.
I push new version with your suggestion !
But I'm not sure about php code style, What is the rule ? Does pipeline check this ?
OskarStark
approved these changes
Apr 26, 2023
OskarStark
reviewed
Apr 26, 2023
Contributor
|
Thanks Antoine. |
OskarStark
force-pushed
the
feature/18230-add-json-mock-response
branch
from
cea8d14 to
b68944c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18230