[HttpClient] Improve the wording about asynchronous requests #21650
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 19, 2025
| Responses are always asynchronous, so that the call to the method returns | ||
| immediately instead of waiting to receive the response:: | ||
| Symfony's HTTP client is asynchronous by default. When you call ``request()``, | ||
| the HTTP request starts immediately, but the method returns without waiting for |
Member
There was a problem hiding this comment.
Suggested change
| the HTTP request starts immediately, but the method returns without waiting for | |
| the HTTP request might start immediately, but the method returns without waiting for |
Member
Author
There was a problem hiding this comment.
But if we say "might start" ... then we need to explain when it starts and when it doesn't. Please, share some details about this. Thanks.
Member
There was a problem hiding this comment.
I don't know, curl does. We don't care here, that's the whole point
| a response. Your code only blocks when you actually need the response data:: | ||
|
|
||
| // code execution continues immediately; it doesn't wait to receive the response | ||
| // the request starts, but execution continues without waiting |
Member
There was a problem hiding this comment.
Suggested change
| // the request starts, but execution continues without waiting | |
| // the request might start, but execution continues without waiting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor change to be more precise about the actual behavior of the HTTP client.