[Monolog] added NotFoundActivationStrategy from MonologBundle #11805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, would it makes sense to make this class more "flexible" like explained in symfony/monolog-bundle#89? ping @lyrixx |
|
see symfony/monolog-bundle#94 for the bundle counterpart. |
|
Just noticed that the class from the bundle uses the request instead of the request stack. I've made a second commit to use the request stack for the class in the bridge. |
fabpot
force-pushed
the
notfound-activation-strategy
branch
from
3491751 to
bf5e9d1
Compare
There was a problem hiding this comment.
Maybe best to move this inline in the if, or at least return early if $isActivated is false, to avoid getting the request every time? Otherwise the PR and RequestStack changes seem fine to me.
fabpot
force-pushed
the
notfound-activation-strategy
branch
from
bf5e9d1 to
b064d2f
Compare
|
👍 |
fabpot
added a commit
that referenced
this pull request
Sep 8, 2014
…gBundle (fabpot) This PR was merged into the 2.6-dev branch. Discussion ---------- [Monolog] added NotFoundActivationStrategy from MonologBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The NotFoundActivationStrategy class from MonologBundle is totally independent of the framework and should be part of the bridge instead. That would allow people to use it easily with Silex for instance. ping @Seldaek Commits ------- b064d2f [Monolog] changed the not found activation strategy to use the request stack 1a239af [Monolog] added NotFoundActivationStrategy from MonologBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NotFoundActivationStrategy class from MonologBundle is totally independent of the framework and should be part of the bridge instead. That would allow people to use it easily with Silex for instance.
ping @Seldaek