New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrowserKit] Uppercase the "GET" method in redirects #19425

Merged
merged 1 commit into from Jul 25, 2016

Conversation

Projects
None yet
5 participants
@jakzal
Member

jakzal commented Jul 25, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19419
License MIT
Doc PR -
@@ -464,7 +464,7 @@ public function followRedirect()
$content = $request->getContent();
}
if ('get' === strtolower($method)) {
if ('GET' === strtoupper($method)) {

This comment has been minimized.

@jakzal

jakzal Jul 25, 2016

Member

This is only changed for consistency.

@jakzal

jakzal Jul 25, 2016

Member

This is only changed for consistency.

@javiereguiluz

This comment has been minimized.

Show comment
Hide comment
@javiereguiluz

javiereguiluz Jul 25, 2016

Member

👍

Status: reviewed

Member

javiereguiluz commented Jul 25, 2016

👍

Status: reviewed

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jul 25, 2016

Member

Thank you @jakzal.

Member

nicolas-grekas commented Jul 25, 2016

Thank you @jakzal.

@nicolas-grekas nicolas-grekas merged commit 7b117d3 into symfony:2.7 Jul 25, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jul 25, 2016

bug #19425 [BrowserKit] Uppercase the "GET" method in redirects (jakzal)
This PR was merged into the 2.7 branch.

Discussion
----------

[BrowserKit] Uppercase the "GET" method in redirects

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19419
| License       | MIT
| Doc PR        | -

Commits
-------

7b117d3 [BrowserKit] Uppercase the "GET" method in redirects
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jul 25, 2016

Member

Thank you @jakzal.

Member

stof commented Jul 25, 2016

Thank you @jakzal.

@jakzal jakzal deleted the jakzal:browserkit-method-name branch Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment