New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Ignore missing tree root nodes on validate #27472

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
6 participants
@ro0NL
Contributor

ro0NL commented Jun 1, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? technically yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27450
License MIT
Doc PR symfony/symfony-docs#...
@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 1, 2018

LGTM, with a test case would be even better :)

@xabbuh

The conflict rule for the DependencyInjection component must now be updated:

"symfony/config": "<4.1.1"
@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Jun 3, 2018

nice catch. Done

status: needs review

@fabpot

fabpot approved these changes Jun 5, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 5, 2018

Thank you @ro0NL.

@fabpot fabpot merged commit b3cdfc6 into symfony:4.1 Jun 5, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2018

bug #27472 [DI] Ignore missing tree root nodes on validate (ro0NL)
This PR was squashed before being merged into the 4.1 branch (closes #27472).

Discussion
----------

[DI] Ignore missing tree root nodes on validate

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | technically yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27450
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

b3cdfc6 [DI] Ignore missing tree root nodes on validate

@ro0NL ro0NL deleted the ro0NL:di/env-config branch Jun 5, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

fabpot added a commit that referenced this pull request Jun 25, 2018

feature #27476 [Config] deprecate tree builders without root nodes (x…
…abbuh)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Config] deprecate tree builders without root nodes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

While reviewing #27472 I wondered if we really need support config trees without a root node. If we did not support it, users wouldn't create pseudo configuration classes when they were actually not needed.

Commits
-------

c2ce153 deprecate tree builders without root nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment