Skip to content

Conversation

@gazi04
Copy link
Contributor

@gazi04 gazi04 commented Sep 7, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #61624
License MIT

This PR includes a comprehensive review of the Albanian translations within the application. The goal was to correct any existing errors and make improvements for better clarity and consistency.

Changes include:

  • Fixed typos and grammatical errors in key phrases.
  • Updated terminology to be more consistent with standard Albanian usage.
  • Improved the overall tone and flow of the translated text.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title 6.4 6.4 Sep 7, 2025
@gazi04 gazi04 changed the title 6.4 Review Albanian translations Sep 7, 2025
@fabpot
Copy link
Member

fabpot commented Sep 8, 2025

@gazi04 Can you fix this PR? The PR contains a lot of unrelated commits.

@gazi04
Copy link
Contributor Author

gazi04 commented Sep 8, 2025

How are you @fabpot, I have a question regarding this problem the solution that I found is to edit the git rebase list my commit is the last on the list and I should drop all the other commits and then I run git push --force-with-lease origin 6.4. Is this the solution?

@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 7.4 September 8, 2025 10:19
@nicolas-grekas
Copy link
Member

Thank you @gazi04.

@nicolas-grekas nicolas-grekas merged commit ee9a821 into symfony:6.4 Sep 8, 2025
8 of 11 checks passed
@carsonbot carsonbot changed the title Review Albanian translations [Validator] Review Albanian translations Sep 8, 2025
@nicolas-grekas
Copy link
Member

I did it by changing the target to 7.4, which your work was based on, then changing the target during the merge - we have a tool that does the rest automatically.
But yes, git rebase is the way.

@gazi04
Copy link
Contributor Author

gazi04 commented Sep 8, 2025

Thanks for everything @nicolas-grekas @fabpot @carsonbot, it's my honor to help in such a beautiful and amazing project with people like you.

@stof
Copy link
Member

stof commented Sep 9, 2025

This broke the CI as the failure reported in https://github.com/symfony/symfony/actions/runs/17547708894/job/49832910785#step:15:183 was related to this PR.

xabbuh added a commit that referenced this pull request Sep 9, 2025
This PR was merged into the 6.4 branch.

Discussion
----------

[Validator] restore translation source entries

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #61678 (comment)
| License       | MIT

Commits
-------

24e8914 restore translation source entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants