-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Validator] Review Albanian translations #61678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
@gazi04 Can you fix this PR? The PR contains a lot of unrelated commits. |
|
How are you @fabpot, I have a question regarding this problem the solution that I found is to edit the git rebase list my commit is the last on the list and I should drop all the other commits and then I run git push --force-with-lease origin 6.4. Is this the solution? |
|
Thank you @gazi04. |
|
I did it by changing the target to 7.4, which your work was based on, then changing the target during the merge - we have a tool that does the rest automatically. |
|
Thanks for everything @nicolas-grekas @fabpot @carsonbot, it's my honor to help in such a beautiful and amazing project with people like you. |
|
This broke the CI as the failure reported in https://github.com/symfony/symfony/actions/runs/17547708894/job/49832910785#step:15:183 was related to this PR. |
This PR was merged into the 6.4 branch. Discussion ---------- [Validator] restore translation source entries | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #61678 (comment) | License | MIT Commits ------- 24e8914 restore translation source entries
This PR includes a comprehensive review of the Albanian translations within the application. The goal was to correct any existing errors and make improvements for better clarity and consistency.
Changes include: