[Lock][DynamoDB] Enable http_client injection and fix tests using AmpV5 client
#62167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
added
❄️ Feature Freeze
GromNaN
force-pushed
the
dynamodb-lock
branch
from
883411e to
0dbeb74
Compare
alexandre-daubois
approved these changes
Oct 27, 2025
GromNaN
commented
Oct 27, 2025
src/Symfony/Component/Lock/Bridge/DynamoDb/Store/DynamoDbStore.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
dynamodb-lock
branch
from
b5c8337 to
75289fa
Compare
|
Thank you @GromNaN. |
nicolas-grekas
added
Bug
and removed
Feature
❄️ Feature Freeze
This was referenced Nov 2, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #62162 to fix the x86 / minimal-exts / lowest-php job in 8.0
In order to compare instances of
DynamoDbStore, we need to inject the sameHttpClientinstance.The
http_clientoption is a feature that enables, for example, injecting a client decorated by the profiler to view the HTTP requests made by the store, and still use the DSN for the lock configuration.