[DomCrawler] Fix converting HTML5 trees to DOM nodes #62186
Merged
+48
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking a second look. I have applied this PR to my live site and the unit tests are passing again, meaning the b/c break has been resolved. |
stof
reviewed
Oct 28, 2025
|
|
||
| private function copyFromHtml5ToDom(\Dom\Node $source, \DOMDocument $target): void | ||
| { | ||
| /** @var list<array{0: iterable<\Dom\Node>, 1: ?\DOMNode}> $stack */ |
There was a problem hiding this comment.
can the key 1 really be nullable ? The code does not handle null values when using it.
There was a problem hiding this comment.
right, I forgot to clean this up from a previous iteration, I'll do a hotpatch
This was referenced Nov 2, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much better than #62180