Skip to content

[Toolkit] Add version-added key in toolkit manifest#3531

Merged
Kocal merged 1 commit into
symfony:3.xfrom
MrYamous:version-added-in-manifest
May 11, 2026
Merged

[Toolkit] Add version-added key in toolkit manifest#3531
Kocal merged 1 commit into
symfony:3.xfrom
MrYamous:version-added-in-manifest

Conversation

@MrYamous
Copy link
Copy Markdown
Contributor

Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? yes
Issues Fix #3509
License MIT

Allow a new version-added key in Toolkit manifest to add it in documentation
I make it nullable cause I think for components which exists for a long time this information is less important. And it allow us to not add it for all components right now

@MrYamous MrYamous requested a review from Kocal as a code owner May 10, 2026 16:50
@carsonbot carsonbot added Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed labels May 10, 2026
@carsonbot carsonbot changed the title add version-added key in toolkit manifest add version-added key in toolkit manifest May 10, 2026
@MrYamous MrYamous changed the title add version-added key in toolkit manifest Add version-added key in toolkit manifest May 10, 2026
@Kocal Kocal added the Toolkit label May 11, 2026
@carsonbot carsonbot changed the title Add version-added key in toolkit manifest [Toolkit] Add version-added key in toolkit manifest May 11, 2026
@Kocal Kocal force-pushed the version-added-in-manifest branch from 23d8436 to 4c4cec8 Compare May 11, 2026 08:53
Copy link
Copy Markdown
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I just pushed on your PR to add some validation, update tests, and the JSON schema (super important!)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 11, 2026
@Kocal
Copy link
Copy Markdown
Member

Kocal commented May 11, 2026

Thank you @MrYamous.

@Kocal Kocal merged commit 2b6a7f5 into symfony:3.x May 11, 2026
28 checks passed
Kocal added a commit that referenced this pull request May 11, 2026
…nt Shadcn UI recipes (Amoifr)

This PR was squashed before being merged into the 3.x branch.

Discussion
----------

[Toolkit] Populate `version-added` on Flowbite 4 and recent Shadcn UI recipes

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no
| Deprecations?  | no
| Issues         | Fix #3509
| License        | MIT

Follow-up to #3531 (which added the `version-added` schema entry): this populates the field for the most recent recipes, so [ux.symfony.com](https://ux.symfony.com) can surface the required Toolkit version to users — the original use case behind #3509.

Two commits, one per period, so the second can be dropped if reviewers prefer to wait for the 3.0 tag:

- `[Toolkit] Populate version-added for Flowbite 4 and recent Shadcn UI recipes` — 24 manifests:
  - `2.33` — `shadcn/{accordion,tabs,tooltip}`
  - `2.35` — `shadcn/toggle` + the 20 Flowbite 4 recipes released with 2.35 (`alert`, `badge`, `button`, `button-group`, `card`, `checkbox`, `indicator`, `input`, `kbd`, `label`, `modal`, `pagination`, `radio`, `select`, `skeleton`, `spinner`, `table`, `tabs`, `textarea`, `toggle`)
- `[Toolkit] Mark unreleased Flowbite 4 and Shadcn UI recipes as added in 3.0` — 8 manifests only present on `3.x`:
  - `flowbite-4/{avatar,dropdown}`
  - `shadcn/{collapsible,hover-card,radio-group,resizable,toggle-group,typography}`

Versions were determined by checking each recipe's presence at the corresponding git tag (e.g. `git ls-tree -r v2.33.0 -- src/Toolkit/kits/`), to avoid being misled by the 2.32 → 2.33 kits reshuffle (#3107) which would have made `git log --follow` unreliable.

Happy to split, narrow scope (e.g. drop the 3.0 commit until release), or change the version format (e.g. `2.35.0` instead of `2.35`) — whatever fits best!

Commits
-------

05cf878 [Toolkit] Populate `version-added` on Flowbite 4 and recent Shadcn UI recipes
@MrYamous MrYamous deleted the version-added-in-manifest branch May 11, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation mentions kit which doesn't exist

3 participants