[Toolkit] Add added-in-version property to Recipe manifests#3532
Closed
Amoifr wants to merge 1 commit into
Closed
Conversation
Adds an optional `added-in-version` property to the Recipe manifest schema, exposed as `RecipeManifest::$addedInVersion`. This unblocks displaying the minimum UX Toolkit version required for each Kit recipe on ux.symfony.com (per the discussion in symfony#3509). The property is purely additive — existing manifests remain valid. A follow-up PR can populate the field on existing recipes once the introduction version of each is identified. Refs symfony#3509
carsonbot
added
Feature
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following @Kocal's suggestion in #3509, this PR introduces an optional
added-in-versionproperty in the Recipe manifest schema. It exposes the value asRecipeManifest::$addedInVersion, ready to be consumed by ux.symfony.com to advertise the minimum UX Toolkit version required for each recipe.Changes
schema-kit-recipe-v1.json: declare the optionaladded-in-versionproperty.Recipe/RecipeManifest.php: new constructor argument + parsing with validation (nullor non-empty string).Tests/Recipe/RecipeManifestTest.php: three new tests (with value, with empty string, with non-string).Scope
Intentionally minimal. Existing manifests are not touched — the field is purely additive and they remain valid. The follow-up effort (populating
added-in-versionon the 51 existing recipes) is more delicate, since several recipes were renamed/restructured (e.g. #3107) and the introduction version doesn't always match the file's git creation date. That part is better driven by the maintainers who know the history, or split into smaller PRs per kit.cc @Kocal — happy to take a stab at the manifest-population follow-up too once this foundation lands, if you'd like.