Skip to content

Bump pybind#426

Closed
aaron-skydio wants to merge 1 commit intoaaron/revup/main/fix-wheelsfrom
aaron/revup/main/sf-pybind
Closed

Bump pybind#426
aaron-skydio wants to merge 1 commit intoaaron/revup/main/fix-wheelsfrom
aaron/revup/main/sf-pybind

Conversation

@aaron-skydio
Copy link
Copy Markdown
Member

@aaron-skydio aaron-skydio commented Feb 24, 2025

Fixes #425

Our previous version of pybind didn't support py3.11. pybind 2.13.6
supports all versions of python that we support. There isn't much
downside to downloading an additional copy of pybind if you have an
older one installed that supports your version of python. If we wanted
to we could write some table of minimum required versions based on
SYMFORCE_PYTHON's version

Topic: sf-pybind
Relative: fix-wheels

@aaron-skydio
Copy link
Copy Markdown
Member Author

aaron-skydio commented Feb 24, 2025

Reviews in this chain:
#427 Fix wheel builds
 └#426 Bump pybind

@aaron-skydio
Copy link
Copy Markdown
Member Author

aaron-skydio commented Feb 24, 2025

# head base diff date summary
0 15a2ace2 d1ced097 diff Feb 23 23:48 PM 1 file changed, 3 insertions(+), 3 deletions(-)
1 6635b417 d1ced097 diff Feb 24 0:48 AM 2 files changed, 37 insertions(+)
2 c59bca28 d1ced097 diff Feb 24 1:41 AM 1 file changed, 4 insertions(+), 4 deletions(-)
3 7e46e98d 8e53c70b diff Feb 24 11:12 AM 4 files changed, 3 insertions(+), 39 deletions(-)

@aaron-skydio aaron-skydio force-pushed the aaron/revup/main/sf-pybind branch 2 times, most recently from 6635b41 to c59bca2 Compare February 24, 2025 09:41
Fixes #425

Our previous version of pybind didn't support py3.11.  pybind 2.13.6
supports all versions of python that we support.  There isn't much
downside to downloading an additional copy of pybind if you have an
older one installed that supports your version of python.  If we wanted
to we could write some table of minimum required versions based on
SYMFORCE_PYTHON's version

Topic: sf-pybind
Relative: fix-wheels
@aaron-skydio aaron-skydio changed the base branch from main to aaron/revup/main/fix-wheels February 24, 2025 19:12
@aaron-skydio aaron-skydio force-pushed the aaron/revup/main/sf-pybind branch from c59bca2 to 7e46e98 Compare February 24, 2025 19:12
@aaron-skydio aaron-skydio mentioned this pull request Feb 24, 2025
@aaron-skydio aaron-skydio deleted the aaron/revup/main/sf-pybind branch March 17, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimizer always segfaults

1 participant