Fix wheel builds#427
Closed
aaron-skydio wants to merge 1 commit intomainfrom
Closed
Conversation
- Rewriting the egg info stopped working at some point. I'm not sure when (they were still getting partly rewritten after the environment variable change so it wasn't that). I can't think of a reason not to do it this way though, which is simpler. - We're more than 300 commits away from the last tag - Don't need to install gmp on macos, it's already installed. Not a necessary change, just suppresses a warning Topic: fix-wheels
Member
Author
Member
Author
Closed
aaron-skydio
added a commit
that referenced
this pull request
Mar 14, 2025
Ok so the tests on #427 don't run the wheel build job, I know I tested that locally but I think I must not have actually run the github action with it. We need to forward this into the cibuildwheel environment Topic: sf-wheels-again Reviewers: brad,nathan,ryan-b GitOrigin-RevId: acdc29bbaed0e4f2d173ef2eed71bfec657f4a49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when (they were still getting partly rewritten after the environment
variable change so it wasn't that). I can't think of a reason not to
do it this way though, which is simpler.
a necessary change, just suppresses a warning
Topic: fix-wheels