Introduce crates as plugins - #266
Merged
Merged
Conversation
Retires source = "crate" skill groups and the crate-metadata redirect schema. A crate is now loaded as a first-class plugin from its [package.metadata.symposium] and/or SYMPOSIUM.toml, merged over the crate defaults by load_crate_manifest and reached through a [[plugins]] source.cargo chained reference; expansion recurses with hyphen/underscore-insensitive cycle and diamond detection. Custom predicates become a boolean gate only; the SDK witness API is kept but marked with a FIXME for future plugin/component field-setting. Refreshes the crate-author and predicate references.
Removes SkillOrigin, OriginSeed, and PluginSource::None, and makes ParsedPlugin.canonical required. A skill's install identity is now the hash of its on-disk SKILL.md path; canonical is used only to key chained-plugin cycle detection. Also drops the now-vestigial ParsedPlugin.source_name field and the dead WORKSPACE_SOURCE_NAME const, and brings the design docs and code comments in line with the new origin model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of the registry-centric plugins RFD.
Disclosure questions
AI disclosure.