Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jul 15, 2025

Closes #69

Changes

  • Max amount calculation
  • Network fee calculation
  • Custom fee screen
    • note: currently we can't customize the channel funding tx fee via ldk-node, so this is only for UI completeness.

Preview

externalNodeFees.mp4

@ovitrif ovitrif self-assigned this Jul 15, 2025
@ovitrif ovitrif mentioned this pull request Jul 14, 2025
@ovitrif ovitrif force-pushed the feat/external-node-fees branch from 9fce186 to 0c5c595 Compare July 15, 2025 14:43
@ovitrif ovitrif marked this pull request as ready for review July 15, 2025 18:18
@ovitrif ovitrif requested a review from jvsena42 July 15, 2025 18:20
ovitrif added 3 commits July 15, 2025 20:37
# Conflicts:
#	app/src/main/java/to/bitkit/repositories/LightningRepo.kt
#	app/src/test/java/to/bitkit/repositories/LightningRepoTest.kt
@ovitrif ovitrif enabled auto-merge July 15, 2025 21:07
@jvsena42
Copy link
Member

The native keyboard looks nice

@ovitrif
Copy link
Collaborator Author

ovitrif commented Jul 16, 2025

The native keyboard looks nice

IDK, IMHO it's not ideal mainly because it has some keys that we don't actually support, and then afaik it will always follow the OS light or dark mode, while the app currently only supports dark theme 🤷🏻

@ovitrif ovitrif merged commit dbab484 into master Jul 16, 2025
1 check passed
@ovitrif ovitrif deleted the feat/external-node-fees branch July 16, 2025 10:21
@ovitrif ovitrif mentioned this pull request Jul 18, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External Node Support

3 participants