Minimal fee checks on RBF #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvsena42
changed the title
jvsena42
commented
Sep 15, 2025
app/src/main/java/to/bitkit/ui/sheets/BoostTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
jvsena42
commented
Sep 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses RBF (Replace-By-Fee) errors caused by low recommended fee rates and improves the latest activities fetching mechanism. The changes implement proper minimum fee rate checks for RBF transactions and make the activities refresh function public for better state management.
- Implements dynamic minimum fee rate calculation for RBF transactions (original fee rate + 2 sat/vbyte)
- Refactors activity list syncing to use explicit fetch calls instead of internal sync methods
- Adds automatic max fee warning display when fee limits are reached
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| BoostTransactionViewModel.kt | Core fee calculation logic with dynamic minimum fee rates for RBF and improved fee validation |
| ActivityListViewModel.kt | Refactored sync method to public fetchLatestActivities for better external access |
| BoostTransactionSheet.kt | Fixed LaunchedEffect dependency to prevent unnecessary re-initialization |
| ActivityDetailScreen.kt | Added activity refresh call after successful boost transaction |
| HomeScreen.kt | Enhanced pull-to-refresh to include latest activities fetch |
| LightningRepo.kt | Increased sync timeout from 15 to 20 seconds |
app/src/main/java/to/bitkit/ui/sheets/BoostTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/sheets/BoostTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
Member
Author
|
couldn't test |
Member
Author
|
Drafted to implement Copilot suggestions |
ovitrif
approved these changes
Sep 15, 2025
Collaborator
|
not sure why the e2e tests are failing 🤷🏻 EDIT: nvm succeeded now except the boost test retriggering ♻️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #374
Description
This PR fixes the RBF error due to a too low recommended fee rate and also improve the latest activities fetching
Preview
cpfp-suggested.webm
rbf-suggested.webm
QA Notes
Tested: