fix: core signal abort crash#989
Merged
Merged
Conversation
673a05f to
3ae7fc2
Compare
ben-kaufman
approved these changes
Jun 4, 2026
Contributor
ben-kaufman
left a comment
There was a problem hiding this comment.
Reviewed locally. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #982
This PR updates Android to consume the
bitkit-coreruntime hardening from synonymdev/bitkit-core#95.Description
This PR:
bitkit-core-androidfrom0.1.64to the released0.1.67artifact.ldk-node-androidunchanged.#982 was reported from production mainnet
2.2.0/ build181during normal wallet and Lightning usage. That build usedbitkit-core-android 0.1.56andldk-node-android 0.7.0-rc.36; its production code exercises native Rust on background workers through wallet sync, activity processing, send/receive/channel flows, Electrum configuration, LDK on-chain payment calls, and bitkit-core address derivation/recovery/database calls.The strongest available symbolication maps the raw Play PCs into
libbitkitcore.so, near the on-chain address-info Electrum/BDK blocking task. The affected production tag does not call the current generated address-info wrapper directly, so this PR describes the risk at the native bitkit-core/Electrum boundary instead of attributing it to one app route. It consumes the core release that keeps unexpected failures in that native on-chain lookup boundary as typed errors rather than native aborts.Related PR #988 only retains native debug symbols for future Play crash symbolication; this PR is the Android dependency bump for the runtime fix.
Preview
N/A
QA Notes
With this fix, we can prove the fixed Rust boundary now converts a synthetic panic into
AccountInfoError::SyncError, which is an error the android side can handle as opposed topanic's; but we cannot say we have a reliable production UI trigger for #982, this crash couldn't be reproduced with a deterministic repro scenario.Manual Tests
regression:Receive → copy/show on-chain address → return Home: receive flow still works.regression:Send → prepare on-chain send with standard fee: fee estimate and confirmation flow still work.Automated Checks
just compilejust testjust lintv0.1.67.AppViewModel.handleScanandSupportScreenimport ordering.