Skip to content

fix: core signal abort crash#989

Merged
ovitrif merged 2 commits into
masterfrom
ovi/fix-982-bitkit-core-0.1.67
Jun 4, 2026
Merged

fix: core signal abort crash#989
ovitrif merged 2 commits into
masterfrom
ovi/fix-982-bitkit-core-0.1.67

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Jun 3, 2026

Fixes #982

This PR updates Android to consume the bitkit-core runtime hardening from synonymdev/bitkit-core#95.

Description

This PR:

  1. Bumps bitkit-core-android from 0.1.64 to the released 0.1.67 artifact.
  2. Keeps ldk-node-android unchanged.
  3. Adds a changelog fragment for the native on-chain lookup crash hardening.

#982 was reported from production mainnet 2.2.0 / build 181 during normal wallet and Lightning usage. That build used bitkit-core-android 0.1.56 and ldk-node-android 0.7.0-rc.36; its production code exercises native Rust on background workers through wallet sync, activity processing, send/receive/channel flows, Electrum configuration, LDK on-chain payment calls, and bitkit-core address derivation/recovery/database calls.

The strongest available symbolication maps the raw Play PCs into libbitkitcore.so, near the on-chain address-info Electrum/BDK blocking task. The affected production tag does not call the current generated address-info wrapper directly, so this PR describes the risk at the native bitkit-core/Electrum boundary instead of attributing it to one app route. It consumes the core release that keeps unexpected failures in that native on-chain lookup boundary as typed errors rather than native aborts.

Related PR #988 only retains native debug symbols for future Play crash symbolication; this PR is the Android dependency bump for the runtime fix.

Preview

N/A

QA Notes

With this fix, we can prove the fixed Rust boundary now converts a synthetic panic into AccountInfoError::SyncError, which is an error the android side can handle as opposed to panic's; but we cannot say we have a reliable production UI trigger for #982, this crash couldn't be reproduced with a deterministic repro scenario.

Manual Tests

  • 1. Mainnet wallet → foreground sync → Activity: wallet data loads without a native crash.
  • 2. regression: Receive → copy/show on-chain address → return Home: receive flow still works.
  • 3. regression: Send → prepare on-chain send with standard fee: fee estimate and confirmation flow still work.

Automated Checks

  • just compile
  • just test
  • just lint
  • Core release validation: fix: guard address info lookup bitkit-core#95 adds focused Rust coverage and publishes v0.1.67.
  • Detekt completed successfully; it printed existing findings in AppViewModel.handleScan and SupportScreen import ordering.

@ovitrif ovitrif force-pushed the ovi/fix-982-bitkit-core-0.1.67 branch from 673a05f to 3ae7fc2 Compare June 4, 2026 07:33
@ovitrif ovitrif added this to the 2.3.0 milestone Jun 4, 2026
@ovitrif ovitrif changed the title fix: consume core crash fix fix: core panic crash Jun 4, 2026
@ovitrif ovitrif changed the title fix: core panic crash fix: core signal abourt crash Jun 4, 2026
@ovitrif ovitrif requested review from ben-kaufman and piotr-iohk June 4, 2026 13:13
@ovitrif ovitrif mentioned this pull request Jun 4, 2026
7 tasks
@ovitrif ovitrif changed the title fix: core signal abourt crash fix: core signal abort crash Jun 4, 2026
Copy link
Copy Markdown
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed locally. No issues found.

@ovitrif ovitrif merged commit 16d6f1f into master Jun 4, 2026
17 checks passed
@ovitrif ovitrif deleted the ovi/fix-982-bitkit-core-0.1.67 branch June 4, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Production SIGABRT in arm64 native code (Play 2.2.0 / build 181)

2 participants