fix: guard address info lookup#95
Merged
Merged
Conversation
3 tasks
7 tasks
ben-kaufman
approved these changes
Jun 4, 2026
Collaborator
ben-kaufman
left a comment
There was a problem hiding this comment.
Approving this as-is for the hotfix.
One follow-up thought: run_account_info_blocking looks like the right pattern for the other onchain BDK/Electrum blocking calls too, like get_account_info, get_transaction_history, and get_transaction_detail. Could we apply it there in a follow-up so this module has one consistent error boundary for account-info blocking work?
coreyphillips
approved these changes
Jun 4, 2026
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
Integrated in:
This PR:
AccountInfoError::SyncErrorinstead of aborting the native process.bitkit-coreto0.1.67, regenerates Android/iOS bindings, and publishes the release Android can consume.Description
Android #982 is a production mainnet SIGABRT from
2.2.0/ build181, reported during normal wallet and Lightning usage: foreground sync, activity, send/receive, channels, and background/foreground transitions. That build usedbitkit-core-android 0.1.56andldk-node-android 0.7.0-rc.36.The available symbolication maps the raw Play PCs into
libbitkitcore.so, near the on-chain address-info Electrum/BDK blocking task. The affected production tag does not call the current generated address-info wrapper directly, so this PR treats the frame as evidence for a native bitkit-core on-chain/Electrum error-boundary problem.This change keeps failures in that address-info boundary inside typed
AccountInfoErrorhandling even if the blocking worker panics or the Tokio task fails, while preserving the existing FFI API surface.Release:
QA Notes
PR is required to fix synonymdev/bitkit-android#982 and must be merged this week to land in
2.3.0.Manual Tests
Automated Tests
src/modules/onchain/tests.rs.cargo test get_address_info -- --nocapturecargo test account_info_blocking_task -- --nocapturecargo test --lib -- --skip modules::blocktankcargo clippy./build_ios.sh./build_android.shGradle Packageforv0.1.67succeeded.cargo testhit unrelated Blocktank staging/network failures; non-Blocktank lib tests passed.