Skip to content

fix: guard address info lookup#95

Merged
ovitrif merged 1 commit into
masterfrom
ovi/fix-982-onchain-address-info-abort
Jun 4, 2026
Merged

fix: guard address info lookup#95
ovitrif merged 1 commit into
masterfrom
ovi/fix-982-onchain-address-info-abort

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Jun 3, 2026

Related to:

Integrated in:

This PR:

  1. Guards the native on-chain address-info lookup boundary so unexpected blocking-task panics and join failures return AccountInfoError::SyncError instead of aborting the native process.
  2. Adds focused Electrum fixture coverage for empty history/UTXOs, malformed responses, disconnects, network mismatch, and runtime task panic handling.
  3. Bumps bitkit-core to 0.1.67, regenerates Android/iOS bindings, and publishes the release Android can consume.

Description

Android #982 is a production mainnet SIGABRT from 2.2.0 / build 181, reported during normal wallet and Lightning usage: foreground sync, activity, send/receive, channels, and background/foreground transitions. That build used bitkit-core-android 0.1.56 and ldk-node-android 0.7.0-rc.36.

The available symbolication maps the raw Play PCs into libbitkitcore.so, near the on-chain address-info Electrum/BDK blocking task. The affected production tag does not call the current generated address-info wrapper directly, so this PR treats the frame as evidence for a native bitkit-core on-chain/Electrum error-boundary problem.

This change keeps failures in that address-info boundary inside typed AccountInfoError handling even if the blocking worker panics or the Tokio task fails, while preserving the existing FFI API surface.

Release:

QA Notes

PR is required to fix synonymdev/bitkit-android#982 and must be merged this week to land in 2.3.0.

Manual Tests

  • Via Android PR.

Automated Tests

  • Tests added: cover address lookup empty history/UTXO, malformed Electrum UTXO/history responses, Electrum disconnects, address/network mismatch, and blocking task panic handling in src/modules/onchain/tests.rs.
  • cargo test get_address_info -- --nocapture
  • cargo test account_info_blocking_task -- --nocapture
  • cargo test --lib -- --skip modules::blocktank
  • cargo clippy
  • ./build_ios.sh
  • ./build_android.sh
  • Release workflow: Gradle Package for v0.1.67 succeeded.
  • Validation gap: full cargo test hit unrelated Blocktank staging/network failures; non-Blocktank lib tests passed.

Copy link
Copy Markdown
Collaborator

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as-is for the hotfix.

One follow-up thought: run_account_info_blocking looks like the right pattern for the other onchain BDK/Electrum blocking calls too, like get_account_info, get_transaction_history, and get_transaction_detail. Could we apply it there in a follow-up so this module has one consistent error boundary for account-info blocking work?

@ovitrif ovitrif merged commit ff0111c into master Jun 4, 2026
1 check passed
@ovitrif ovitrif deleted the ovi/fix-982-onchain-address-info-abort branch June 4, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Production SIGABRT in arm64 native code (Play 2.2.0 / build 181)

3 participants