Skip to content

test: add hardware wallet e2e on ios#618

Open
piotr-iohk wants to merge 3 commits into
masterfrom
test/hw-wallet-e2e-ios
Open

test: add hardware wallet e2e on ios#618
piotr-iohk wants to merge 3 commits into
masterfrom
test/hw-wallet-e2e-ios

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Refs #589

This PR:

  1. Aligns hardware wallet accessibility identifiers with the Android E2E suite so Appium can drive connect, rename, delete, transfer, and settings flows on iOS.
  2. Adds Trezor bridge plist keys and enables Trezor bridge in the local E2E app build.
  3. Wires @hardware_wallet specs into the self-hosted local iOS E2E job (with Trezor emulator image pull), running serially alongside the existing local grep list.

Linked Issues/Tasks

Refs #589

Companion PR: synonymdev/bitkit-e2e-tests#195

Screenshot / Video

N/A

QA Notes

Manual Tests

N/A

Automated Checks

  • iOS E2E helpers updated in companion bitkit-e2e-tests PR: actions.ts adds cross-platform id-prefix matching; hardware-wallet.ts fixes rename/delete taps on iOS.
  • Local E2E workflow adds @hardware_wallet to the existing e2e-tests-local grep, pulls the Trezor emulator image, and builds with TREZOR_BRIDGE=true / TREZOR_BRIDGE_URL=http://127.0.0.1:21325.
  • Hardware wallet specs exercised locally on iOS simulator with BACKEND=local: @hardware_wallet_1, @hardware_wallet_2, @hardware_wallet_3 pass.
  • CI: local iOS E2E shard runs on the self-hosted macOS runner after merge (workflow changes only apply to PRs opened after this merges).

@greptile-apps

greptile-apps Bot commented Jul 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds iOS coverage for hardware wallet E2E flows. The main changes are:

  • Hardware wallet accessibility identifiers aligned for Appium.
  • Trezor bridge plist keys added to the app build.
  • Local iOS E2E workflow extended to include hardware wallet specs.
  • Trezor emulator image pull added before local E2E execution.

Confidence Score: 4/5

The hardware wallet E2E workflow path can fail because the bridge image is pulled but the bridge service is not started.

  • The app is built with Trezor bridge enabled for local E2E.
  • The workflow includes @hardware_wallet tests in the local shard.
  • The compose startup does not include the trezor profile, so the bridge endpoint can be unavailable when those tests run.
  • The Swift accessibility and plist changes did not show another concrete runtime issue.

.github/workflows/e2e-tests.yml

Important Files Changed

Filename Overview
.github/workflows/e2e-tests.yml Enables Trezor bridge config and hardware wallet tests, but only pulls the emulator image instead of starting the profiled service.
Bitkit/Info.plist Adds Trezor bridge and electrum plist substitutions for runtime config lookup.
Bitkit/Views/Settings/General/HardwareWalletsSettingsScreen.swift Adds hardware wallet settings accessibility containers and updates row identifiers and tap targets.
Bitkit/Views/Sheets/HardwareConnect/HwFoundView.swift Renames found-state accessibility identifiers and adds a screen accessibility container.
Bitkit/Views/Sheets/HardwareConnect/HwPairedView.swift Adds a screen accessibility container to the paired hardware wallet view.
Bitkit/Views/Sheets/HardwareConnect/HwSearchingView.swift Renames searching-state accessibility identifiers and adds a screen accessibility container.
Bitkit/Views/Sheets/HardwareConnectSheet.swift Renames intro sheet accessibility identifiers and adds a screen accessibility container.
Bitkit/Views/Transfer/Hardware/SpendingAmountHw.swift Adds a hardware transfer amount screen accessibility identifier and container.
Bitkit/Views/Transfer/Hardware/SpendingHwSign.swift Adds a hardware transfer signing screen accessibility identifier and container.
Bitkit/Views/Wallets/HardwareWalletScreen.swift Adds a hardware wallet detail screen accessibility identifier and container.

Reviews (1): Last reviewed commit: "ci: add hardware wallet e2e to local ios" | Re-trigger Greptile

Comment thread .github/workflows/e2e-tests.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1081e125c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/e2e-tests.yml
@piotr-iohk piotr-iohk requested a review from jvsena42 July 8, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant