Skip to content

chore: update fx rates endpoint#624

Merged
jvsena42 merged 2 commits into
masterfrom
chore/update-endpoint
Jul 14, 2026
Merged

chore: update fx rates endpoint#624
jvsena42 merged 2 commits into
masterfrom
chore/update-endpoint

Conversation

@pwltr

@pwltr pwltr commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description

Update FX rates endpoint to no longer use old Blocktank service.

See https://synonymworkspace.slack.com/archives/C07BJ7DNPCG/p1784012810894369

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown

Greptile Summary

This PR moves the production FX rates request off the old Blocktank service.

  • Updates the Bitcoin btcRatesServer URL.
  • Leaves signet, testnet, and regtest rates URLs unchanged.

Confidence Score: 5/5

This looks safe to merge after confirming the new rates endpoint returns the same public JSON contract.

  • The code change is limited to one production URL constant.
  • The existing caller expects an unauthenticated JSON response with a top-level tickers array.
  • No blocking issue was found in the changed code.

Bitkit/Constants/Env.swift

Important Files Changed

Filename Overview
Bitkit/Constants/Env.swift Changes the production FX rates endpoint used by currency rate fetching.

Reviews (1): Last reviewed commit: "docs: update changelog" | Re-trigger Greptile

Comment thread Bitkit/Constants/Env.swift

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url return matches the current model

@jvsena42
jvsena42 enabled auto-merge July 14, 2026 12:40

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url response matches the project model

@jvsena42
jvsena42 merged commit a565bd9 into master Jul 14, 2026
11 checks passed
@jvsena42
jvsena42 deleted the chore/update-endpoint branch July 14, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants