fix: Czech backup notification plural#628
Merged
Merged
Conversation
Greptile SummaryThis PR fixes the Czech backup-failure countdown text. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| Bitkit/Resources/Localization/cs.lproj/Localizable.strings | Updates the Czech plural pattern to match the formatter's supported one and other syntax. |
| changelog.d/next/cs-backup-plural.fixed.md | Adds an accurate release note for the corrected Czech notification. |
Reviews (1): Last reviewed commit: "chore: rename changelog fragment" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 278be2545d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Czech backup-failure notification so its retry countdown renders correctly instead of leaking raw placeholder text.
Description
The Czech translation of
settings__backup__failed_messageused a translated word (dalších) where ICU plural syntax requires the literalotherkeyword. On iOS this string is formatted by the app's lenient regex-based plural helper rather than a strict ICU parser, so the malformed pattern does not crash the app (unlike the equivalent Android bug in synonymdev/bitkit-android#1080). Instead the regex simply fails to match, and Czech users see the raw pattern —{interval, plural, one {# minute} dalších {# minutes}}— literally in the backup-failure toast.This corrects the Czech string to use the valid
otherkeyword. An audit of all 13 locale string files confirmed this was the only malformed plural entry; every other plural already uses valid keywords, and Italian (which was also broken on Android) was already correct here.Note: translations are synced from Transifex, so the same correction should also land upstream to avoid a future sync reintroducing it.
Linked Issues/Tasks
Related Android fix: synonymdev/bitkit-android#1080
QA Notes
Manual Tests
{interval, plural, ...}placeholder.regression:Device language set to English → trigger the same backup-failure notification: toast still shows "Retrying in N minute(s)" correctly.Automated Checks
LocalizeHelpers.swift.