This repository was archived by the owner on Feb 8, 2026. It is now read-only.
feat(wallet): Show info toast when hiding balance#1498
Merged
coreyphillips merged 3 commits intomasterfrom Jan 18, 2024
Merged
Conversation
b76c6b7 to
1c2f14e
Compare
Contributor
Author
|
Checked with Aldert and confirmed this is needed also in the wallet detail view. |
pwltr
approved these changes
Jan 15, 2024
Contributor
Author
|
|
coreyphillips
approved these changes
Jan 16, 2024
1c2f14e to
071ddad
Compare
Contributor
Author
Updated the PR with logic to show the toast only once. |
pwltr
suggested changes
Jan 16, 2024
071ddad to
ce8d274
Compare
pwltr
approved these changes
Jan 16, 2024
coreyphillips
approved these changes
Jan 16, 2024
Contributor
Author
|
The PIN e2e test keeps failing repeatedly but I saw it failing on other PRs as well, don't really think the problem comes from the changes. I will retrigger the e2e tests again. |
Contributor
|
And now tests will fail because blocktank staging is down 🫠 |
7 tasks
ce8d274 to
95628a5
Compare
Contributor
Author
|
Blocktank staging still down, hence the tests kept failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a toast message to explain the hidden wallet balance state for user clarity and resolution.
Works on both:
Linked Issues/Tasks
Design v45 (see slack message or Figma file)
Type of change
Tests
Screenshot / Video
qemu-system-aarch64.2024-01-15.001412.mp4
QA Notes
See above video.