Skip to content
This repository was archived by the owner on Feb 8, 2026. It is now read-only.

feat(wallet): Show info toast when hiding balance#1498

Merged
coreyphillips merged 3 commits intomasterfrom
feat/wallet-balance-hide-toast
Jan 18, 2024
Merged

feat(wallet): Show info toast when hiding balance#1498
coreyphillips merged 3 commits intomasterfrom
feat/wallet-balance-hide-toast

Conversation

@ovitrif
Copy link
Copy Markdown
Contributor

@ovitrif ovitrif commented Jan 15, 2024

Description

Added a toast message to explain the hidden wallet balance state for user clarity and resolution.

Works on both:

  • wallets overview (home) and
  • asset (Bitcoin) overview.

Linked Issues/Tasks

Design v45 (see slack message or Figma file)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

qemu-system-aarch64.2024-01-15.001412.mp4

QA Notes

See above video.


@ovitrif ovitrif force-pushed the feat/wallet-balance-hide-toast branch from b76c6b7 to 1c2f14e Compare January 15, 2024 15:41
@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented Jan 15, 2024

Checked with Aldert and confirmed this is needed also in the wallet detail view.

@ovitrif ovitrif marked this pull request as ready for review January 15, 2024 15:42
@ovitrif ovitrif changed the title feat(wallet): Show info toast when hiding balance on Home feat(wallet): Show info toast when hiding balance Jan 15, 2024
@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented Jan 16, 2024

⚠️ Need to make the toast show only once (the first time the user performs the action),
as suggested by Aldert (thanks @flaviomoceri)

@pwltr pwltr self-requested a review January 16, 2024 11:08
@ovitrif ovitrif force-pushed the feat/wallet-balance-hide-toast branch from 1c2f14e to 071ddad Compare January 16, 2024 13:19
@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented Jan 16, 2024

⚠️ Need to make the toast show only once (the first time the user performs the action), as suggested by Aldert

Updated the PR with logic to show the toast only once.

@ovitrif ovitrif requested a review from coreyphillips January 16, 2024 13:21
Comment thread src/store/slices/user.ts
@ovitrif ovitrif force-pushed the feat/wallet-balance-hide-toast branch from 071ddad to ce8d274 Compare January 16, 2024 14:01
@ovitrif ovitrif requested a review from pwltr January 16, 2024 14:10
@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented Jan 17, 2024

The PIN e2e test keeps failing repeatedly but I saw it failing on other PRs as well, don't really think the problem comes from the changes.

I will retrigger the e2e tests again.

@limpbrains
Copy link
Copy Markdown
Contributor

And now tests will fail because blocktank staging is down 🫠

@ovitrif ovitrif force-pushed the feat/wallet-balance-hide-toast branch from ce8d274 to 95628a5 Compare January 17, 2024 15:51
@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented Jan 18, 2024

Blocktank staging still down, hence the tests kept failing

@coreyphillips coreyphillips merged commit 29fa2bf into master Jan 18, 2024
@coreyphillips coreyphillips deleted the feat/wallet-balance-hide-toast branch January 18, 2024 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants