workshop: P1-5 instance lock/descriptor and P1-6 CUA exact process - #86
Merged
Conversation
flock the data-root lock before tauri::Builder, name the holder, and resolve identity from the bundle descriptor first so a .dev. bundle cannot open the canonical profile. Co-authored-by: Cursor <cursoragent@cursor.com>
Stdio adapters share instance_paths.rs instead of each copying the canonical Application Support fallback, so a descriptor-only launch still finds the instance data root. Co-authored-by: Cursor <cursoragent@cursor.com>
Treat another owner's fresh heartbeat as live so a second process does not steal turns, and refuse to overwrite eval-driver.json when /health still answers for a different pid. Co-authored-by: Cursor <cursoragent@cursor.com>
running_apps returns every pid per bundle id; resolve never launches and errors ambiguous_target when more than one copy is live. Launch is its own allowlisted verb. Mutating verbs check Workshop /health identity, and Laguna stop uses shared ProcessIdentity. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instance.lockbeforetauri::Builder; descriptor-first identity; adapters shareinstance_paths.rs;is_livetreats a fresh peer heartbeat as live; eval driver refuses overwrite when/healthis another pid.running_appsreturns every pid;resolvenever launches and errorsambiguous_target; explicitlaunchverb; mutating verbs check Workshop/health; Laguna stop uses sharedProcessIdentity.Rebased onto current
v0.7(includes W3a launcher half).Locks:
instance::22,recovery::18, eval-driver health 3, helperapps::5, helper full 35.Test plan
cargo test --offline --lib instance::cargo test --offline --lib recovery::cargo test --offline --features eval-driver --lib eval_driver::tests::a_cargo test --offline --manifest-path helpers/synth-computer-use/Cargo.tomlMade with Cursor