fix(charts): resync drifted CRDs from base + add make sync-chart-crds - #31
Merged
Conversation
The Helm chart CRDs under charts/imp-crds/templates had drifted from config/crd/bases: impnetworks, impvmrunnerpools, impvmtemplates, and impwarmpools were missing schema added since (expireAfter, scaling modes, groupCIDRs, VTEP list-map-key, etc.), so a chart install shipped stale CRDs that reject valid spec fields. Resync all ten from base and add a make sync-chart-crds target (base + helm.sh/resource-policy: keep) so the chart CRDs regenerate mechanically and cannot silently drift again. make manifests only writes the base copies; there was no automation keeping the chart in step.
The smoke suite installs the Helm chart CRDs, which were stale and
lacked the scaling.mode + CEL validations now synced from base. The
fixture used the deprecated scaling {minIdle, maxConcurrent} +
jobDetection.webhook shape, which the corrected CRD rejects. Move it to
scaling.mode=webhook with explicit minIdle/maxConcurrent/scaleUpStep/
cooldownSeconds + scaling.webhook.secretRef. Demand=2 capped at
scaleUpStep=2 still yields the 2 VMs the test asserts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Helm chart CRDs under
charts/imp-crds/templateshad drifted fromconfig/crd/bases. Four were missing schema added since they were last hand-synced:groupCIDRsstatus,ipam.cidr, VTEPx-kubernetes-list-map-keysscaling.mode/webhook/polling,cooldownSeconds,expireAfter, CEL validationsexpireAfterexpireAfterA chart install therefore shipped stale CRDs that reject valid spec fields.
Fix: resync all ten chart CRDs from base, and add
make sync-chart-crdsso they regenerate mechanically (base +helm.sh/resource-policy: keep) and cannot silently drift again.make manifestsonly writes theconfig/crd/basescopies — there was no automation keeping the chart in step.Each chart CRD is now byte-for-byte
base+ the singleresource-policyannotation (verified). kubeconform in CI validates the chart CRDs.