Add Syscoin Core 5.1.0 Alpine image - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aab31c1f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #### Regtest | ||
|
|
||
| - JSON-RPC/REST: 18443 | ||
| - JSON-RPC/REST: 38370 |
There was a problem hiding this comment.
Swap the regtest and signet RPC ports
Syscoin Core 5.1 uses RPC port 18470 for regtest and 38370 for signet, but these values are assigned to the opposite networks here. Consequently, the preceding -regtest=1 example publishes and curls port 38370 even though the daemon listens on 18470, so the documented RPC request cannot connect; swap these values and update the regtest example accordingly.
Useful? React with 👍 / 👎.
Summary
v5.1.0and sysgethv5.1.0syscoin/syscoin-core:5.1.0andlatestto the same image buildValidation
v5.1.0tagssyscoind -versionreportsv5.1.0syscoin-cli -versionreportsv5.1.0sysgeth versionreports5.1.0-stableat commit3e3248c58bdbca963ca45dd4452c6774fff12118latestand5.1.0resolve to the same local image IDdocker buildx build --check 5.1/alpinesh -n 5.1/alpine/docker-entrypoint.shgit diff --check