Name deferral as a register class - #363
Open
alanhc wants to merge 2 commits into
Open
Conversation
The Pull requests section bars pasted walkthroughs and status tables, and says a reply carries the correction, the measurement, or nothing. It does not name the sentence that closes a reply by offering to redo the change if the reviewer would prefer it, which PR#350 rejected on sight. That is the artifact the two earlier citations were already about, in a politer form. It asks the reviewer for an instruction instead of stating a position, and the tradeoff it puts up for a vote had been measured before the reply was written.
The register binds PR bodies and review replies and names the classes that mark machine-written prose. One was missing: text about the writer rather than about the work. PR#350 carried an instance. A paragraph closed a measured decision by offering to reverse it on request, and the maintainer quoted it back with "Let's concentrate on real discussions!". The same shape reaches review text as an apology for a correction and as an announcement of candor before a caveat that stands on its own. An offer to redo the work another way asks the reviewer to choose between two shapes the writer has already measured, and the decision plus the reason that settles it is what they needed instead. A reviewer who disagrees says so without being invited.
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/skills/elfuse-conventions/SKILL.md">
<violation number="1" location=".claude/skills/elfuse-conventions/SKILL.md:383">
P3: This guidance describes the rule with a metaphor and an uncheckable politeness comparison instead of naming the deferral directly. Replace it with a factual description such as “A reply that asks the reviewer to choose between measured alternatives is a deferral.”</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| correction, the measurement, or nothing. A concise what and why belongs in | ||
| the commit body, not the thread. | ||
|
|
||
| A reply that hands the choice back is the same artifact in a politer form: |
There was a problem hiding this comment.
P3: This guidance describes the rule with a metaphor and an uncheckable politeness comparison instead of naming the deferral directly. Replace it with a factual description such as “A reply that asks the reviewer to choose between measured alternatives is a deferral.”
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .claude/skills/elfuse-conventions/SKILL.md, line 383:
<comment>This guidance describes the rule with a metaphor and an uncheckable politeness comparison instead of naming the deferral directly. Replace it with a factual description such as “A reply that asks the reviewer to choose between measured alternatives is a deferral.”</comment>
<file context>
@@ -380,6 +380,14 @@ addressed threads with "Resolve conversation"; a reply carries the
correction, the measurement, or nothing. A concise what and why belongs in
the commit body, not the thread.
+A reply that hands the choice back is the same artifact in a politer form:
+"If you would rather the source read uniformly one way or the other, say so
+and I will move the remaining three" asks the reviewer for an instruction
</file context>
Suggested change
| A reply that hands the choice back is the same artifact in a politer form: | |
| A reply that asks the reviewer to choose between measured alternatives is a deferral: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references/prose-register.mdnames the classes that mark machine-writtenprose, and binds PR bodies and review replies alongside source comments and
docs/. One class was missing: text about the writer rather than about thework.
#350 carried an instance. A reply closed a decision that had already been
measured by offering to reverse it on request, and the answer was "Let's
concentrate on real discussions!". The same shape reaches review text as an
apology for a correction, and as an announcement of candor in front of a
caveat that stands on its own.
Two commits, one per surface, following the split the register states in its
own opening: the register defines a class, and a
SKILL.mdsection namesthat class's instance on one surface.
neighbouring case of writing about the writer.
sentence and citing Reject a PI waiter from any plain requeue #350 the way the rules around it cite PR#21, PR#41 and
PR#209.
Why it costs a reviewer something: an offer to redo the work another way asks
them to choose between two shapes the writer has already measured, when the
decision and the reason that settles it were what they needed. A reviewer who
disagrees says so without being invited.
Verification
scripts/check-skill-refs.pyresolves every path, target, section andcross-reference across the 12 files under
.claude/, andscripts/check-commit-log.shaccepts both commits. Documentation only: nobuild or test target reads these files.
Summary by cubic
Names deferral and self-report as a prose-register class so guidance can flag text about the writer instead of the work. Pull request replies should state a measured decision and its reason rather than hand the choice back to the reviewer.
Written for commit b1349a0. Summary will update on new commits.